Repository navigation
Add new features to ensure we do not lose functionality from what was… - #345
Open
SharonStrats wants to merge 6 commits into
Open
SharonStrats wants to merge 6 commits into
SharonStrats wants to merge 6 commits into
Conversation
… offered in the sharing Pane Prompt: Many prompts to get this correct. This will most likely change a bit as well once we decide for sure if this is the correct approach Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SharonStrats
force-pushed
the
feat/acl-match-legacy
branch
from
October 19, 2026 04:00
cd425e0 to
1e8e448
Compare
Prompt: Split shared direct authorizations when downgrading or revoking one subject. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
Prompt: Make sure to copy over any conditions even though this is not currently supported in solidos we don't want to lose this information if a user has it. Also make authorization ids consistent. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
Prompt: Please normalize the role handling and add the ability to have a owner (write locked) which is read and control. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
ACL rewrites can broaden restricted access, retain revoked permissions, remove unrelated grants, and bypass controller safeguards.
8 open issues
What changed in this PR
Extends SolidOS access-control logic to support container sharing scopes and restore missing sharing-pane functionality.
Changes:
- Adds scoped container grants, inheritance handling, and ACL reset operations.
- Adds storage safeguards, scope analysis, and write-locked owner mapping.
- Expands tests and updates the package version.
| File | Description |
|---|---|
| test/resourceLogic.test.ts | Extends ACL API mocks. |
| test/publicAclApi.test.ts | Checks new public exports and types. |
| test/aclLogic.test.ts | Tests scoped grants, inheritance, and safeguards. |
| src/types.ts | Extends the ACL interface. |
| src/index.ts | Exports scope helpers and role definitions. |
| src/acl/aclLogic.ts | Implements expanded ACL behavior. |
| package.json | Bumps the package version. |
| package-lock.json | Synchronizes version metadata. |
Review effort: Balanced
Prompt: multiple to help resolve PR feedback Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
marked this pull request as ready for review
October 20, 2026 11:12
timea-solid
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this work is that in testing, a couple of things were discovered.
The following is a list of things that were added to support the missing features in the access control dialog:
Note: there is one thing still missing is that the current Sharing Pane also has one more role it's Owner (write locked), almost like a "Sharing Manager" so with this permission, which is ['Read', 'Control'] the user can change permissions, but not write to the resource.